-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binder not working #3070
Comments
I updated the fork based off jsp 4.4.1. New fork: jupyterhub/jupyter-server-proxy@main...fonsp:jupyter-server-proxy:okt-2024 Updating pluto-on-binder: fonsp/pluto-on-binder#22 |
It works!!! |
I ran a notebook with |
Still needs a Pluto release |
Since we downgraded to Julia 1.10 it would also be good to fix #3071 |
Binder is not working for Pluto 0.20 and 0.20.1:
I think the jupyter-server-proxy extension is not working (404 means that the proxy did nothing).
My guess is that the binder base image has a new version of jupyterlab or notebook or sth and jsp is no longer compatible.
Changelogs show this: https://github.com/jupyterhub/jupyter-server-proxy/blob/main/docs/source/changelog.md (we use 1.5.1 right now).
Here is the fork we use: http://github.com/fonsp/jupyter-server-proxy
and the setup file where this is specified: https://github.com/fonsp/pluto-on-binder/blob/master/setup.py
I also recently found out about https://github.com/yuvipanda/jupyter-pluto-proxy which might be a good place to start over!
The reason we have a fork of jsp is to allow CORS websocket requests. You can see this in the diff of my fork:
jupyterhub/jupyter-server-proxy@main...fonsp:jupyter-server-proxy:master
The text was updated successfully, but these errors were encountered: