Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder not working #3070

Closed
fonsp opened this issue Oct 22, 2024 · 8 comments · Fixed by fonsp/pluto-on-binder#22
Closed

Binder not working #3070

fonsp opened this issue Oct 22, 2024 · 8 comments · Fixed by fonsp/pluto-on-binder#22

Comments

@fonsp
Copy link
Owner

fonsp commented Oct 22, 2024

Binder is not working for Pluto 0.20 and 0.20.1:

image

I think the jupyter-server-proxy extension is not working (404 means that the proxy did nothing).

My guess is that the binder base image has a new version of jupyterlab or notebook or sth and jsp is no longer compatible.

Changelogs show this: https://github.com/jupyterhub/jupyter-server-proxy/blob/main/docs/source/changelog.md (we use 1.5.1 right now).

Here is the fork we use: http://github.com/fonsp/jupyter-server-proxy
and the setup file where this is specified: https://github.com/fonsp/pluto-on-binder/blob/master/setup.py

I also recently found out about https://github.com/yuvipanda/jupyter-pluto-proxy which might be a good place to start over!

The reason we have a fork of jsp is to allow CORS websocket requests. You can see this in the diff of my fork:

jupyterhub/jupyter-server-proxy@main...fonsp:jupyter-server-proxy:master

@fonsp fonsp changed the title Binder not working? Binder not working Oct 25, 2024
@fonsp
Copy link
Owner Author

fonsp commented Oct 25, 2024

I updated the fork based off jsp 4.4.1. New fork: jupyterhub/jupyter-server-proxy@main...fonsp:jupyter-server-proxy:okt-2024

Updating pluto-on-binder: fonsp/pluto-on-binder#22

@fonsp
Copy link
Owner Author

fonsp commented Oct 25, 2024

It works!!!

@fonsp
Copy link
Owner Author

fonsp commented Oct 25, 2024

Owww but now it crashed while loading the notebook

image

It happens while the PlutoRunner boot env is instantiating, let me try moving that to the binder build phase.

@fonsp
Copy link
Owner Author

fonsp commented Oct 27, 2024

Stuck still

image

@fonsp
Copy link
Owner Author

fonsp commented Oct 27, 2024

High memory usage, close to limit

image

Maybe an option to disable the "Loading notebook boot environment" in parallel?

@fonsp
Copy link
Owner Author

fonsp commented Oct 28, 2024

I ran a notebook with Pkg.activate(), so no pluto managed Pkg, and it's still stuck on "Loading notebook boot environment". top shows a Julia process at 100% CPU, and it's not the Pluto server. RAM was not limited

@fonsp
Copy link
Owner Author

fonsp commented Oct 28, 2024

Still needs a Pluto release

@fonsp
Copy link
Owner Author

fonsp commented Oct 28, 2024

Since we downgraded to Julia 1.10 it would also be good to fix #3071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant