You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the useModalWithSubject and useOverlayWithSubject hooks, the subject state is kept around even after the modal/overlay is closed. It doesn't cause any particular issues, but it does hold on to an object reference that could otherwise be garbage collected.
Would require something like an onUnmount callback in ModalProvider/PopoverProvider so that the consumer gets notified when the unmount happens and the state can be reset.
The text was updated successfully, but these errors were encountered:
In the
useModalWithSubject
anduseOverlayWithSubject
hooks, the subject state is kept around even after the modal/overlay is closed. It doesn't cause any particular issues, but it does hold on to an object reference that could otherwise be garbage collected.Would require something like an
onUnmount
callback inModalProvider
/PopoverProvider
so that the consumer gets notified when the unmount happens and the state can be reset.The text was updated successfully, but these errors were encountered: