Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog header/footer shifting in Safari #90

Open
mkrause opened this issue Jan 5, 2025 · 1 comment
Open

Dialog header/footer shifting in Safari #90

mkrause opened this issue Jan 5, 2025 · 1 comment

Comments

@mkrause
Copy link
Collaborator

mkrause commented Jan 5, 2025

See the "Dialog With Title Overflow" story in Safari and try scrolling. There's some minor 1px shifting going on and I haven't been able to fix it. Even removing the -1px pixel rounding fix does not work. Probably better to just move away from the position: sticky solution and move to a CSS grid here instead.

EDIT: This is also very apparent during the entry animation of a DialogModal, the footer shifts significantly.

@mkrause
Copy link
Collaborator Author

mkrause commented Jan 7, 2025

Another thing we should fix as part of this ticket is the focus outline on slide modals. Currently it's outset which gets cut off at the top and bottom. We can do:

    &.bk-dialog-modal--slide-over {
      @include bk.focus-inset;
    }

However that doesn't work currently due to the header/footer having z-index: 1. Turning it into a grid should solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants