-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE11 image resizing bug using Cards and Flexbox #10079
Comments
@IamManchanda ever seen anything like this? I can't figure out why it is happening. |
@bgarrant Will look soon .... Currently busy with some other tasks! |
Thanks for posting this! I haven't seen it before which is odd. Looks like that flexbug you linked to is the reason - looks there is a workaround in the post or using smaller images might help. Since it's not directly repeated to a Foundation component we'll close this here. |
The fix in that link did not work for me. |
I also tried running postcss-flexbugs-fixes with no luck |
This seems to fix the issue, but it seems like we may need a card wrapper element for images to avoid this IE11 issue. We have
|
I can confirm that adding a |
I don't know right now whether the above comments helps or not... But reopening based on above comments |
@IamManchanda Let me know what you think |
I will surely let you know... Will test it out tomm and let you know! |
In the meantime if you can provide a codepen example then that will be great! |
I am not sure how to do that @IamManchanda. This code above should reproduce the issue on F 6.3.1. Can you use it? |
@IamManchanda Any chance to look at this Harry? The fix seems to work but not sure if best way. |
Oh sorry i missed the last comment .... PS: This pen includes foundation with flex grid, motion ui so you just need to add your code! |
Please check out this fix in the CSS. If you add that class to wrap images it fixes the IE11 bug. |
Yup just tested in IE11 We dont have a |
Glad we were able to find a fix. |
@IamManchanda do you have a way to test in IE10 just so we know it works with all the browser Foundation supports? |
Good. Just an IE11 issue then.
|
Changes - Fix browser specific bug - Update docs!
Ohk i added a PR #10082 .... |
Closes #10079 - Fix a flexbug for cards on IE11
I just launched a site with Foundation 6.3.1 and when doing testing in IE11, we have noticed a bug when using the card component and flexbox. It appears that the images and not collapsing even though visually they look correct. There is extra added space under each image that happens to match the original image size. The bug looks like it may be same as this one: philipwalton/flexbugs#75.
You can see the issue on two sites we have: https://www.consinfo.com/ and https://www.lakechamplainpools.com/pools/inground. There is a bunch of added space under each image when using the card component and IE11. Here is my code from consinfo.com. Sites looks perfect in all other browsers.
The text was updated successfully, but these errors were encountered: