Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle panic_data in Deploy #47

Closed
cptartur opened this issue Jul 6, 2023 · 0 comments · Fixed by #118
Closed

Handle panic_data in Deploy #47

cptartur opened this issue Jul 6, 2023 · 0 comments · Fixed by #118
Assignees
@Arcticae

Comments

@cptartur
Copy link
Member

cptartur commented Jul 6, 2023

software-mansion/protostar#2024

Source: https://github.com/software-mansion/protostar/blob/0a0748e80ded1b03392daecda17e65efbce265dc/protostar-rust/src/cheatcodes_hint_processor.rs#L156

Edit:
Most of the errors should not be recoverable, excluding those with txn execution (which is handled by panic_data).

Separately, we should consider avoiding having error_code in cases which we always return 0

Edit2:
Delegated Invokes and Calls error handling to #2156
@cptartur cptartur added this to the Forge milestone Jul 6, 2023
@cptartur cptartur moved this to In Progress in Starknet foundry Jul 6, 2023
@Arcticae Arcticae mentioned this issue Jul 11, 2023
Merged
Arcticae added a commit that referenced this issue Jul 11, 2023
@Arcticae @cptartur
Handle deploy panic data (#118)
31e0a10 
Closes #47

---------

Co-authored-by: Artur Michałek <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Jul 11, 2023
@MaksymilianDemitraszek MaksymilianDemitraszek removed this from the Forge milestone Jul 26, 2023
Utilitycoder pushed a commit to Utilitycoder/starknet-foundry that referenced this issue Oct 6, 2023
@enitrat
refactor:exercises order (foundry-rs#47)
7e64ca0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arcticae Arcticae

Labels
None yet
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle deploy panic data foundry-rs/starknet-foundry
3 participants
@MaksymilianDemitraszek @Arcticae @cptartur