Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adv/Disadv/Normal Attack Buttons and Crit Damage Button colours/highlights.... #4968

Open
YenBenGrey opened this issue Jan 6, 2025 · 1 comment
Labels
accessibility ui User interface related features or bugs

Comments

@YenBenGrey
Copy link

Hello there,

When the attack card pops up for a player/GM to make an attack, would it be possible that the button that is in play be made more obvious. Currently it is a thin red line around the button and not particularly obvious.

The same for damage buttons. So normal or crit is more obvious.

Which brings me to the next part, unless there is something wrong that I am not sure about, when a crit hit happens the damage button is still highlighting in the thin red line around normal damage. Is it possible for the damage button to relate to the type of attack, whether it is 'normal' or 'critical'? (And as above to make the button more obvious to the onlooker, some folk with accessibility issues do struggle)

(I am using dark mode, so maybe that has some influence)

Thank you

@arbron arbron added ui User interface related features or bugs accessibility labels Jan 6, 2025
@roth-michael
Copy link
Contributor

Re: the Critical button not highlighting, I think that's an actual bug. In the #rollDamage function of AttackActivity ,lastAttack should (I think) be getting checked for whether it was a crit, and if so be passing along { options: { defaultButton: "critical" } } as a second arg to rollDamage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ui User interface related features or bugs
Projects
None yet
Development

No branches or pull requests

3 participants