Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heart of Ice and Heart of Fire effects for Mantle of Frozen and Magma Heart spells #17894

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Heart of Ice and Heart of Fire effects for Mantle of Frozen and Magma Heart spells #17894

wants to merge 3 commits into from

Conversation

ammalagonc
Copy link
Collaborator

Addresses/closes #17890

@ammalagonc ammalagonc added the pr: data update Updates to existing actors and items label Jan 2, 2025
@TikaelSol
Copy link
Collaborator

Is there a reason to add new effects for this? Seems like these could be a single effect with suboptions for which one is active.

@ammalagonc
Copy link
Collaborator Author

ammalagonc commented Jan 5, 2025 •
edited
Loading

Damage received doesn't recognize any of the predicates - one suggestion was to add a self:xxx to make it stick but was a bit of hack.

I slept on it and, decided to give the hack a try, and it works. Much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mantle of the Frozen Heart Spell Effect Description False
2 participants
@ammalagonc @TikaelSol