Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review email configuration #2224

Closed
tcompa opened this issue Jan 28, 2025 · 0 comments · Fixed by #2241
Closed

Review email configuration #2224

tcompa opened this issue Jan 28, 2025 · 0 comments · Fixed by #2241

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jan 28, 2025

We have mail_settings.use_starttls, and we should add mail_settings.use_login (defaulting to True).
Ref:


Let's also take this opportunity to make the configuration variables more readable. First guess, it should be like this:

  1. All FRACTAL_EMAIL_* variables are optional
  2. As soon as one of the variables is set, all of them are required.
  3. Exceptions:
    • FRACTAL_EMAIL_USE_{STARTTLS,LOGIN} should be optional and default to True
    • FRACTAL_EMAIL_PASSWORD should only be required if FRACTAL_EMAIL_USE_LOGIN is set to True
  4. FRACTAL_EMAIL_PASSWORD should still be handled the same way as now (with fernet encryption)
@tcompa tcompa assigned ychiucco and mfranzon and unassigned ychiucco Jan 29, 2025
@tcompa tcompa changed the title Expose possibility of skipping SMTP login in email notification Review email configuration Feb 3, 2025
@tcompa tcompa assigned ychiucco and unassigned mfranzon Feb 3, 2025
@ychiucco ychiucco linked a pull request Feb 3, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants