You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a possible edge case that I don't know how to handle.
Suppose to have an image with an attribute having key = k1 and value = v1. Then, the user opens the dataset filters modal and add an attribute filter selecting k1 and v1 from the dropdown selectors that have been built based on the image page. After that, the user removes the image and opens the dataset filters modal again. The modal is not able to list k1 and v1 in the dropdown menus, because these values don't exist anymore.
Should I just ignore them and not display them to the UI?
Another possibility could be to let the backend removing the invalid dataset filters when an image is deleted.
Removal of image list entries should be rare. If we do hit that edge case, it's a good question on how we want to proceed.
If we just keep the filter in place, it shouldn't interfere with any functionality. Because these attribute filters are "OR" inclusion filters, having e.g. 10 entries, only 9 of which really exist for key k wouldn't be an issue.
If all entries with key k are removed, that's a different story, but that should be super rare.
Thus, when an entry gets removed, I don't have a strong opinion on whether we keep showing the filter values. We'll always have to show all filter keys though.
Branching from #689 for a specific topic.
Originally posted by @zonia3000 in #689
Originally posted by @jluethi in #689
The text was updated successfully, but these errors were encountered: