Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on newer clang (LLVM 17) #115

Closed
VelocityRa opened this issue Jun 18, 2024 · 2 comments
Closed

Build failure on newer clang (LLVM 17) #115

VelocityRa opened this issue Jun 18, 2024 · 2 comments

Comments

@VelocityRa
Copy link
Contributor

VelocityRa commented Jun 18, 2024

At least one issue is that adapter_common.h includes <cstdint> but uses uint8_t etc types, even though these are only guaranteed to exist under std:: (unlike with stdint.h).

@fraillt
Copy link
Owner

fraillt commented Jul 28, 2024

mmm... you're right :/ maybe I should update this. It should be hard though basically search/replace all intX_t, uintX_t and size_t by adding std:: prefix.

@VelocityRa
Copy link
Contributor Author

VelocityRa commented Jul 28, 2024

Apparently there's no need, as long as you make a new release :)
Please see #117 (comment) for details and thanks a lot!

@fraillt fraillt closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants