Reason for removing FSK_FRAME_MODE_8N1_FRAMES?

[InterLinked1]

This is more of an information request than a bug, per se.

In this commit from 2012, FSK_FRAME_MODE_8N1_FRAMES was removed:
4265af6#diff-f39a1bf3eb4f90837f55490c3be3d02e605bb22dde779084f0d5f45a8dfc5970

FSK_FRAME_MODE_7E1_FRAMES has the same value as this (10), but semantically it means something very different.

What is the replacement for this macro? Not sure I follow this change, given that 8N1 is the most common modem setting, and the remaining settings are quite obscure. I am trying to fix code that doesn't compile because it uses the removed FSK_FRAME_MODE_8N1_FRAMES macro, and it isn't clear what the replacement should be, since 8N1 is simply gone.

[InterLinked1]

So 19 months later and there is still no answer on this... @coppice-git is it safe to say there simply was and is no reason and this definition should be re-added? Lately it seems there has been a lot of breakage in SpanDSP for breakage's sake.

[coppice-git]

On 31/07/2023 16:06, InterLinked1 wrote: So 19 months later and there is still no answer on this... @coppice-git <https://github.com/coppice-git> is it safe to say there simply /was and is no reason/ and this definition should be re-added? Lately it seems there has been a lot of breakage in SpanDSP for breakage's sake. — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APIVPKKDIGEWSHBC2KRLG7DXS7CZDANCNFSM5K4ZG5DQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

It was removed because it was not properly implemented in the software, and was a dead end approach anyway. The whole async scheme was a bit half baked, because it was originally only implemented to support a couple of specific things, like FAX. Some of the recent changes replace what was there with a flexible scheme for UART operation, where you specify the data bits, parity type and stop bits, and can mix them any way you want. The bit stream processing is more robust, too. This is in preparation for more data modem functionality in the library. What is that broken definition being used for? Regards, Steve

[InterLinked1]

Hi, Steve,
Thanks for the context. It's a bit unclear to me as all the other modes are there, except 8N1, but as stated 8N1 is the most common modem setting (8 data bits, no parity, 1 stop bit) so I guess my question is what should be used instead then?

Here is an example where this is used: https://github.com/alessandrocarminati/app-fsk/blob/master/app_fsk_18.c#L49