Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph view lacks a way of zooming the time horizontally #313

Closed
pgilfernandez opened this issue Nov 9, 2024 · 9 comments · Fixed by #318
Closed

Graph view lacks a way of zooming the time horizontally #313

pgilfernandez opened this issue Nov 9, 2024 · 9 comments · Fixed by #318
Labels
Milestone

Comments

@pgilfernandez
Copy link

pgilfernandez commented Nov 9, 2024

The only way of zooming is the "fit vertical" but:

In the "keyframes timeline" you can do:

  • middle mouse button: pan left/right
  • ctrl/command + mouse scroll: zoom in/out

In the "graph timeline" you can do:

  • middle mouse button: pan left/right/up/down
  • ctrl/command + mouse scroll: zoom in/out VERTICALLY (center of zoom in the middle of your window)
  • ctrl/command + alt + mouse scroll: zoom in/out VERTICALLY (center of zoom in the mouse pointer position)
  • ...

Maybe I'm missing something but there is not an option to zoom in/out HORIZONTALLY while in the "graph timeline"

I would say that the UX way would be to set "ctrl/command + shift + mouse scroll"... but I don't know, maybe it's not the best way. What I really mean is that this feature is missing and it would be useful.

Thanks!

@pgilfernandez pgilfernandez changed the title Graph view lacks a way of zooming the time Graph view lacks a way of zooming the time horizontally Nov 9, 2024
@rodlie
Copy link
Member

rodlie commented Nov 11, 2024

This is a duplicate of #160

Will look into this later today.

@rodlie
Copy link
Member

rodlie commented Nov 11, 2024

So, just add ctrl+wheel to zoom? like this:

friction-graph-zoom-2024-11-11_18.26.55.mp4

@rodlie rodlie added this to the 1.0.0 milestone Nov 11, 2024
@rodlie rodlie added the ux label Nov 11, 2024
@rodlie rodlie closed this as completed in 3073b68 Nov 11, 2024
@adambelis
Copy link

ah yes this seems to fix issue thanks .

also noticed that Alt+scrolling is behiwing strangely seemst o always scroll down . doies not seems like very suful feature to me . if iw tould scroll letf to right that seeesm to be more useful but this should be probably new issue.

simular problem shift+alt will always zoomout. agan felles glichy and not very useful i would rather just ignore alt in this scenario if there is no useful feature.

contrl+shif scrolling should zoom in anod out in both axies currently one is always ignored

@rodlie
Copy link
Member

rodlie commented Nov 12, 2024

also noticed that Alt+scrolling is behiwing strangely seemst o always scroll down . doies not seems like very suful feature to me

Then don't use it ;) The timeline/graph does not use the Alt modifier for anything.

But Qt does(?): https://forum.qt.io/topic/120028/wheel-event-direction-changing-when-pressing-alt-key

contrl+shif scrolling should zoom in anod out in both axies currently one is always ignored

ctrl+shift does nothing in the code, you either use ctrl or shift. What do you mean by both axies?

@adambelis
Copy link

adambelis commented Nov 12, 2024

i am very used to tring all modifiers since every app . Its not best us if if modifier does nothing useless other then defoult behavior :D .

for ctrl+shift it is more of feature request

I'm imagaging something like scaling in time + in values ate the same time

Cinema_4D_gujmOPVTKq.mp4

@rodlie
Copy link
Member

rodlie commented Nov 12, 2024

i am very used to tring all modifiers since every app . Its not best us if if modifier does nothing useless other then defoult behavior :D .

Looking at the code we do not use the Alt modifier in the timeline/graph, since we don't capture that event it just gets propagated up the chain in Qt and something default is used I assume. We should probably capture Alt events and ignore them if we don't use them, that way "odd" behavior does not happen.

for ctrl+shift it is more of feature request

Ok will look into that.

Will reopen this issue, else it will be forgotten ;)

@rodlie rodlie reopened this Nov 12, 2024
@adambelis
Copy link

or i can open new issue so its less messy ?

@rodlie
Copy link
Member

rodlie commented Nov 12, 2024

Sure, that also works.

@adambelis
Copy link

#320

@rodlie rodlie closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants