Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and validate a data package descriptor, including profile-specific validation via the registry of JSON Schemas #6

Closed
7 tasks done
georgeslabreche opened this issue Nov 12, 2017 · 5 comments

Comments

@georgeslabreche
Copy link

georgeslabreche commented Nov 12, 2017

Read and validate a data package descriptor, including profile-specific validation via the registry of JSON Schemas.

@georgeslabreche
Copy link
Author

@roll I think the only think missing thing here is was "Support strict validation flag," which I implemented as as new issue I created, issue #17, and "Profile-specific validation via the registry of JSON Schemas."

For "Read and validate a data package descriptor," I've updated the README to document how this has been implemented.

I'm not exactly sure what is meant by "Profile-specific validation via the registry of JSON Schemas," even after reviewing the specs. Does it simply mean that the data under "resources" needs to conform to the given the profile? For instance, if I have profile:"tabular-data-resource" then the files assigned to the data property need to be validated as CSV and then that CSV needs to be valid with respect to the provided schema (if a schema is provided in the first place)?

@roll
Copy link
Member

roll commented Nov 13, 2017

@georgeslabreche
Cool. Could you please post an update to frictionlessdata/software-legacy#26 (requirements I should mark as done)? I think I've reviewed the Java libs when this one has been just bootstrapped.

Related to validation:

@georgeslabreche
Copy link
Author

@roll I'm bypassing the registry and checking if the profile files exist directly. Is this OK or is there a particular reason why the registry exists and why I should scan it before trying to read the profile file in question?

@roll
Copy link
Member

roll commented Nov 29, 2017

@georgeslabreche
I do the same for other implementations. For now a concept that we sheep profiles with the libraries so on low-level it's enough to check e.g. for {profile-id}.json file in profiles.

Registry could start to be more important e.g. if later we provide API like package = Package(..., remote_registry=True/http://...). But after specs have introduced concept of descriptor.profile = local/remote path there is a question do we need it at all. Because with descriptor.profile a descriptor could contain 100% of information not relaying on concrete implementations.

@georgeslabreche
Copy link
Author

@roll I'll mark this as Done then :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants