Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Darwin Core Archives without metafile #10

Open
niconoe opened this issue Sep 20, 2019 · 1 comment
Open

Support for Darwin Core Archives without metafile #10

niconoe opened this issue Sep 20, 2019 · 1 comment

Comments

@niconoe
Copy link
Contributor

niconoe commented Sep 20, 2019

According to the standard, you can have a perfectly valid DwC-A without a meta.xml given that:

  • there's only a (core) data file
  • that data file has one header row
  • the Metadata is kept in a file named EML.xml

I tried to convert a test archive, but I got:

Traceback (most recent call last):
  File "/anaconda/envs/fdwca_pip_test/bin/fdwca", line 10, in <module>
    sys.exit(cli())
  File "/anaconda/envs/fdwca_pip_test/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/anaconda/envs/fdwca_pip_test/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/anaconda/envs/fdwca_pip_test/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/anaconda/envs/fdwca_pip_test/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/anaconda/envs/fdwca_pip_test/lib/python3.7/site-packages/FrictionlessDarwinCore/fdwca.py", line 13, in cli
    da.save(outpath)
  File "/anaconda/envs/fdwca_pip_test/lib/python3.7/site-packages/FrictionlessDarwinCore/archive.py", line 74, in save
    zf.writestr('readme.md', self.metadata.as_markdown())
AttributeError: 'NoneType' object has no attribute 'as_markdown'
@andrejjh
Copy link
Collaborator

andrejjh commented Oct 7, 2019

In a first step, I suggest to have a more explicit error saying 'no meta.xml found'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants