Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and missing buttons? #62

Open
grashalm4u opened this issue Oct 18, 2024 · 6 comments
Open

Update and missing buttons? #62

grashalm4u opened this issue Oct 18, 2024 · 6 comments

Comments

@grashalm4u
Copy link

Hello Fritz,

I would like to know whether an update of the sharehuttons is planned in the near future.
The Twitter-X has already been noted, and as far as I know, there is no more Google+.
In the current sprites of the Boxxed theme there are no more icons for printing and creating PDF's. Is that intended? Or will you implement these two icons again?

Greetings, grashalm

@fritzmg
Copy link
Owner

fritzmg commented Oct 18, 2024

In the current sprites of the Boxxed theme there are no more icons for printing and creating PDF's. Is that intended? Or will you implement these two icons again?

The icons themeselves are not from me. See https://github.com/fritzmg/contao-sharebuttons?tab=readme-ov-file#icon-sources

@grashalm4u
Copy link
Author

grashalm4u commented Oct 18, 2024

Aah, yes, you are right, now I remember: I created them myself at the time and integrated my own two graphics for printing and creating pdf and used an adapted CSS. Is there still the support of the two functions in the template?
Will you still adapt the X-icon and delete the G+ icon? Or shall I do that by myself, if there is support for X in your template?
Do I need the dompdf- or the tcpdf-extension to implement the "creating pdf function"?

@fritzmg
Copy link
Owner

fritzmg commented Oct 18, 2024

Is there still the support of the two functions in the template?

Contao 5 does not have article PDF printing support anymore.

Will you still adapt the X-icon and delete the G+ icon?

No, likely not. Having PNG icons for this is not state of the art anymore anyway. Plus some of the icon sets don't exist anymore I think.

@grashalm4u
Copy link
Author

Thanks for your answer.

If I have seen it correctly, your extension will support PDF files (see the template). This means that by changing the standard graphics of the Boxxed theme and an adjustment of the CSS, I could achieve the generation of PDF files from my page content, right?
For this I need one of the two extensions DOMPDF or TCPDF, right?

@fritzmg
Copy link
Owner

fritzmg commented Oct 19, 2024

Only in Contao 3 and 4. Contao 5 does not support this anymore.

@grashalm4u
Copy link
Author

What a pity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants