Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate hash for index.json requests (FSharp.Formatting issue) #33

Open
dsyme opened this issue Aug 1, 2020 · 0 comments
Open

Generate hash for index.json requests (FSharp.Formatting issue) #33

dsyme opened this issue Aug 1, 2020 · 0 comments
Labels
fsdocs This is really an issue in FSharp.Formatting

Comments

@dsyme
Copy link
Contributor

dsyme commented Aug 1, 2020

The index.json search index cached by browsers may become out of date as the site gets refreshed

This is an FSharp.Formatting issue (specifically in fsdocs-search.js) noted by @baronfel in #27 (comment)

Cool. How do we check that? Here's the request: fsprojects/FSharp.Formatting@master/docs/content/fsdocs-search.js#L14

Regarding this point, I'd suggest that that content rendered by the templating engine render the content, and provide a hashed value for this specific content

Then, when rendering links/src elements to generated content files, append the hash to the query string. This would mean that urls like the one in the search JS you linked would need to be templated as well. Same for css links in the html head elements, etc.

@dsyme dsyme changed the title Generate hash for index requests (F#F issue) Generate hash for index.json requests (FSharp.Formatting issue) Aug 1, 2020
@dsyme dsyme added the fsdocs This is really an issue in FSharp.Formatting label Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fsdocs This is really an issue in FSharp.Formatting
Projects
None yet
Development

No branches or pull requests

1 participant