Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Support for openmc.CylindricalMesh #8

Open
RemDelaporteMathurin opened this issue Feb 15, 2022 · 4 comments
Open

Support for openmc.CylindricalMesh #8

RemDelaporteMathurin opened this issue Feb 15, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@RemDelaporteMathurin
Copy link
Member

This currently doesn't support MeshFilter with CylindricalMesh

@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Feb 15, 2022
@RemDelaporteMathurin
Copy link
Member Author

by replacing _find_coords_of_mesh by

def find_coords_of_mesh(mesh: openmc.CylindricalMesh):

    xs = mesh.r_grid
    ys = mesh.phi_grid
    zs = mesh.z_grid

    return xs, ys, zs

This could work, although it produces a cartesian mesh

@shimwell
Copy link
Member

I think a deep dive into the vtk package would be needed

cartesian mesh != CylindricalMesh

@RemDelaporteMathurin
Copy link
Member Author

After a deep dive into the VTK pacakge, I made a PR to OpenMC directly (see openmc-dev/openmc#2096)

This PR also works for RegularMesh and RectilinearMesh so we could potentially get rid of this package if this gets merged in

@shimwell
Copy link
Member

Great stuff Remi. These little packages are great places to develop ideas but ultimately it is more ideal if we can move these features in to the main code. This will be particularly nice as the core of this code came from Patrick who is an OpenMC developer so it is one big circle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants