Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'add_gan_loss' is not in the command line for training #13

Open
sanazsab opened this issue Mar 9, 2022 · 3 comments
Open

'add_gan_loss' is not in the command line for training #13

sanazsab opened this issue Mar 9, 2022 · 3 comments

Comments

@sanazsab
Copy link

sanazsab commented Mar 9, 2022

Hi,

why the store action is true in DRM? It does not include in the command line for training. However, FND and BND are dependent on this argument.

parser.add_argument('--add_gan_loss', action='store_true', help='if specified, use gan loss')

Thanks

@fyviezhao
Copy link
Owner

Actually, the gan loss is not used and thus this line of add_argument is redundant. FND and BND are therefore not used, either.

@sanazsab
Copy link
Author

Actually, the gan loss is not used and thus this line of add_argument is redundant. FND and BND are therefore not used, either.

Thanks,

why they are not used? The accuracy hasn't changed with the gan loss?
And why they were added in the code?

@sanazsab
Copy link
Author

Actually, the gan loss is not used and thus this line of add_argument is redundant. FND and BND are therefore not used, either.

Because in this case, there is no discriminator and there is just a generator. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants