Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should be in the patientDescription component? #19

Open
fschiettecatte opened this issue Jun 27, 2018 · 6 comments
Open

What should be in the patientDescription component? #19

fschiettecatte opened this issue Jun 27, 2018 · 6 comments
Labels
component Issues to do with specific individual components

Comments

@fschiettecatte
Copy link
Contributor

Title says it all, components/patientDescription in the request needs work.

@Relequestual
Copy link
Member

This is a little ambigious. What are the issues you see?

@fschiettecatte
Copy link
Contributor Author

I was not sure how to fit the patient data we have into the various fields described there. If it looks ok to you then I am ok with leaving it as is.

@harindra-a
Copy link
Contributor

I wonder if we can again fall back on the MME "_field" format and promote those slowly into full fields as we test things out. Or simply add them as fields to start with if you need them. We can chat at next meeting on this too.

@Relequestual Relequestual changed the title components/patientDescription needs work What should be in the patientDescription component? Jul 6, 2018
@Relequestual
Copy link
Member

@fschiettecatte ah, so you meant the patientDescription component needs work, as in "components.patientDescription", not the "components and patientDescription need work", right?

Assuming so, I'm updating the title to reflect.

@Relequestual Relequestual added the component Issues to do with specific individual components label Jul 6, 2018
@Relequestual
Copy link
Member

@harindra-a I think it's good that we continue to discuss specific components now, and work out how each of the pioneering services can break down their models into components, or break down existing formats like MME into almost identicall components.

Discussion about underscore prefixing is in #17, which I think we should adopt, as the positives far outweigh any negatives.

@harindra-a
Copy link
Contributor

yup, agreed, that sounds good @Relequestual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Issues to do with specific individual components
Projects
None yet
Development

No branches or pull requests

3 participants