Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define that for a search request, components are the search components #25

Closed
Relequestual opened this issue Jul 5, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@Relequestual
Copy link
Member

#11 asks if we need to specify the versions of components in the search component.
My intention was to never have a "search component", and in stead allow components at the root level of a search request to represent the components to be used by a search, and then to have metadata components in the metadata object (meta.components).

If I can get a few nods that this makes sense, I'll make a PR.
Otherwise, we need further discussion.

(Blocks #11 )

@fschiettecatte
Copy link
Contributor

This is fine with me.

@Relequestual Relequestual self-assigned this Aug 1, 2018
@Relequestual
Copy link
Member Author

It looks like after this discussion, I've defined that search components be nested under query.components. I think this was to align better with other proposals. (see model 2 in ga4gh-discovery/data-connect#32 (comment))
As such I'll close this, and #11.

@fschiettecatte Please re-open if you fee this is not OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants