Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how collected use cases are accommodated #74

Closed
mcupak opened this issue Mar 20, 2019 · 7 comments
Closed

Show how collected use cases are accommodated #74

mcupak opened this issue Mar 20, 2019 · 7 comments
Milestone

Comments

@mcupak
Copy link

mcupak commented Mar 20, 2019

There are currently 2 documents containing use cases from driver projects and various groups of GA4GH (that I'm aware of): old use case document, new use case document.

Some of them are rather complex and it's not immediately clear to me if they can be accommodated by the API. Show that this can be done, or update the API to make it possible.

@mcupak mcupak added this to the 1.0.0 RC6 milestone Mar 20, 2019
@kemp-google
Copy link

This would be very helpful to me as a newcomer to the conversation. I would greatly appreciate clarity around the use cases and how they can be translated into queries against the API.

@Relequestual
Copy link
Member

Super. This looks like it should be a high priority!

@Relequestual
Copy link
Member

I've done some tidying of the documents in the GA4GH Search API Google Drive folder.

I've separated the responses from Driver Projects to the use case collection document, from other non Driver Project feedback and ideas.

Currently, from what I can tell, we only have TWO official responses from the use case collection document, although one of them covers two Driver Projects.

I'd like for the validation of the specification to be based mainly on the official responses from Driver Projects.

I'm not suggesting we shouldn't cover use cases presented by individuals and non-officially contributed use cases, but we have to be stategic in terms of prioritisation, which should be Driver Project feedback.

@Relequestual
Copy link
Member

Looking at the two linked documents from the first post, most of the use cases presented by users are to do with types of data. The components architecture means that any type of data is supported as long as someone has defined the schema.

Can either of you (or anyone else) draw out some requirements which are not related to specific data types?

For example, the ability to limit the results and support pagination is an issue not yet covered by the Search API (It was agreed it would be post v1.0.0, but I'm re-opening that as an option). ga4gh-discovery/data-connect#14

@Relequestual
Copy link
Member

OR, if there are queries you feel are complex and you'd still like to see how it could work with the components structure, please let me know!

@mcupak @kemp-google

@mcupak
Copy link
Author

mcupak commented Apr 8, 2019

@Relequestual Sounds good, I'll take a look in the next couple of days and document here. Thanks!

Any feedback is valuable and we don't have a lot of it from DP, so I wouldn't discard the responses just because they're not in some official format, but I agree with the DP-first approach. I also think it could be valuable to demonstrate the use cases that have to do with types of data even if it's just about showing components, as it might not be immediately obvious how to implement this to people coming from outside, and it's a good sanity check for us too. We can also further use this to guide people to adopt the API.

@mcupak
Copy link
Author

mcupak commented Jun 12, 2019

Superseded by ga4gh-discovery/data-connect#1.

@mcupak mcupak closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants