Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 1 - Review by MattColu #3

Open
MattColu opened this issue Oct 22, 2022 · 0 comments
Open

Lab 1 - Review by MattColu #3

MattColu opened this issue Oct 22, 2022 · 0 comments

Comments

@MattColu
Copy link

Major

As @srrmtt pointed out in #2, you're not actually using an A*, but a more sophisticated Greedy Algorithm, however I do think that the second criterion you selected is quite valid.
The first one, not so much, as the length of an option doesn't really imply much for the quality of the choice, if not to discriminate between two options that cause the same number of repetitions (in that case longer might be better, as you assumed for the second criterion).

Minor

  • You might improve the performance of your algorithm by removing duplicate lists from the initial problem (though probably relevant only for small N's)
  • Plz inclue some results in the readme thx
  • ⁽ʳᵉᵃᵈᵐᵉ ᵃˡˢᵒ ʰᵃˢ ˡᵒᵗˢ ᵒᶠ ᵗʸᵖᵒˢ⁾
@MattColu MattColu changed the title Review by MattColu Lab 1 - Review by MattColu Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant