Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark XCM weights in a better way #989

Open
dmoka opened this issue Jan 14, 2025 · 1 comment · May be fixed by #995
Open

Benchmark XCM weights in a better way #989

dmoka opened this issue Jan 14, 2025 · 1 comment · May be fixed by #995
Assignees
@dmoka
Labels
area/runtime priority/high type/enhancement New feature or request

Comments

@dmoka
Copy link
Contributor

dmoka commented Jan 14, 2025 •
edited
Loading

image

Link1:

hydration-node/runtime/hydradx/src/xcm.rs

Line 194 in 02adadc

type Weigher = FixedWeightBounds<BaseXcmWeight, RuntimeCall, MaxInstructions>;

LInk2:

hydration-node/runtime/hydradx/src/xcm.rs

Line 122 in 02adadc

pub const BaseXcmWeight: XcmWeight = XcmWeight::from_parts(100_000_000, 0);

Most parachain uses FixedWeightBounds, but many system chains use WeightInfoBounds

It seems like we should also utilize WeightInfoBounds to have more representative weights
@dmoka
Copy link
Contributor Author

dmoka commented Jan 14, 2025

You can use pallet-xcm-benchmarks. You need to configure it in your runtime and then run benchmarks. You'll end up with these files. The generic and fungible ones are autogenerated and the mod.rs you just copy and paste, it references the correct ones

@dmoka dmoka self-assigned this Jan 15, 2025
@dmoka dmoka linked a pull request Jan 22, 2025 that will close this issue
Open
5 tasks
@dmoka dmoka linked a pull request Jan 22, 2025 that will close this issue
feat: add xcm benchmarking #995
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmoka dmoka

Labels
area/runtime priority/high type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add xcm benchmarking galacticcouncil/hydration-node
2 participants
@jak-pan @dmoka