Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to call recog methods via m(args) #276

Open
ssiccha opened this issue Jun 17, 2021 · 1 comment
Open

Remove the ability to call recog methods via m(args) #276

ssiccha opened this issue Jun 17, 2021 · 1 comment

Comments

@ssiccha
Copy link
Collaborator

ssiccha commented Jun 17, 2021

This is something @fingolfin proposed in #263. Currently we can't do this, since for example the method FewGensAbelian explicitly calls KnownNilpotent. If we had something like suggested in #271 then we could tell recog to call KnownNilpotent next and then return. That should resolve most of the situations where currently we call a method directly from inside another method. What do you think @fingolfin?

Of course we could also simply convert all calls of the form m(args) into calls which use CallRecogMethod.

@fingolfin
Copy link
Member

I think my proposal was to convert m(args) to CallRecogMethod(m, args) (or whatever the right syntax is).

As such, I am not sure what the problem is in FewGensAbelian, nor do I understand how this relates to #271. It feels as if you had something more in mind than what you actually wrote down above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants