Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename or revise RECOG.IsScalarMat, it is misleading #300

Open
fingolfin opened this issue Nov 17, 2021 · 1 comment
Open

Rename or revise RECOG.IsScalarMat, it is misleading #300

fingolfin opened this issue Nov 17, 2021 · 1 comment

Comments

@fingolfin
Copy link
Member

This function name suggests that true or false is returned, which is not what it does (see code comments for an explanations).

As a result, some code is using it incorrectly (I'll submit a fix shortly)
@fingolfin
Copy link
Member Author

See #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fingolfin