Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in slnconstr.gi: Error, ModRat: for <r>/<s> mod <n>, <s>/gcd(<r>,<s>) and <n> must be coprime #313

Open
fingolfin opened this issue Mar 11, 2022 · 3 comments
Labels
bug: unexpected error A computation runs into an error loop when it should not have bug Any bug should have this label, even if it also has a more generic label

Comments

@fingolfin
Copy link
Member

The following input file triggers an error:
bug_O_C2_NonIsometric_-1_6_9.txt

with 2   3 field=9  5 FFFKF
Error, ModRat: for <r>/<s> mod <n>, <s>/gcd(<r>,<s>) and <n> must be coprime in
  LogFFE( det, Z( q ) ) / gcd / (d / gcd) mod ((q - 1) / gcd)
  at GAPROOT/pkg/recog/gap/matrix/slconstr.gi:1250 called from
SLCR.SLSLPbb( ri!.data, x, ri!.dimension
 ) at GAPROOT/pkg/recog/gap/matrix/slconstr.gi:2472 called from
slpforelement( ri )( ri, x ) at GAPROOT/pkg/recog/gap/base/recognition.gi:711 called from
SLPforElement( rifac, gg ) at GAPROOT/pkg/recog/gap/base/recognition.gi:733 called from
slpforelement( ri )( ri, x ) at GAPROOT/pkg/recog/gap/base/recognition.gi:711 called from
SLPforElement( KernelRecogNode( ri ), z!.el
 ) at GAPROOT/pkg/recog/gap/base/kernel.gi:55 called from
...  at bug_O_C2_NonIsometric_-1_6_9.txt:95
type 'quit;' to quit to outer loop
brk>

Perhaps @danielrademacher has some insights on this code?

@fingolfin fingolfin added bug Any bug should have this label, even if it also has a more generic label bug: unexpected error A computation runs into an error loop when it should not have labels Mar 11, 2022
@fingolfin
Copy link
Member Author

This was originally reported by @TristanPfersdorff on gap-packages/ClassicalMaximals#111

@danielrademacher
Copy link
Collaborator

On my system the recognition fails but no error occurs (but I have an old version of the Recog package).

On the current master branch of recog I also get the error. So it has to do with some commit after Oct 7, 2021.

@danielrademacher
Copy link
Collaborator

danielrademacher commented Mar 21, 2022

It's not as easy as I thought to find the commit from which the error occurs. I may have also changed functions locally, which means that the error no longer occurs. I'll take a closer look at this.

It looks as if the recognition no longer fails and the function is called as a result. It probably wasn't like that in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: unexpected error A computation runs into an error loop when it should not have bug Any bug should have this label, even if it also has a more generic label
Projects
None yet
Development

No branches or pull requests

2 participants