Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying double-slash in TestDirectory output #5249

Closed
fingolfin opened this issue Dec 6, 2022 · 1 comment · Fixed by #5252
Closed

Annoying double-slash in TestDirectory output #5249

fingolfin opened this issue Dec 6, 2022 · 1 comment · Fixed by #5252

Comments

@fingolfin
Copy link
Member

Recently messages printed by TestDirectory started to look like this:

/home/runner/gap/pkg/hap-1.47//tst/...

Notice the double slash. Not terrible bad, but annoying.

I suspect (but did not check, and thus might be totally wrong) that PR #5178 by @zickgraf could have started this.

If right, then one way to changes this would be to adjust things to be kind of the opposite: instead of ensuring there is always a trailing slash, we could ensure there is never a trailing slash; I think both are fine as long as we are consistent.

Another fix would be to adjust the TestDirectory code specifically to avoid the double slash. But I wonder if there are other places that might be similarly affected...

@zickgraf
Copy link
Contributor

zickgraf commented Dec 7, 2022

If right, then one way to changes this would be to adjust things to be kind of the opposite: instead of ensuring there is always a trailing slash, we could ensure there is never a trailing slash; I think both are fine as long as we are consistent.

I think having the trailing slash is a good thing because it ensures compatibility with Directory, which always adds a trailing slash. So if other places are affected, I think they should simply be changed to use Directory and Filename, which should be more stable and consistent than handling file paths as strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants