Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for more accepting states #36

Open
gaperez64 opened this issue Jul 31, 2023 · 3 comments
Open

Allow for more accepting states #36

gaperez64 opened this issue Jul 31, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@gaperez64
Copy link
Owner

gaperez64 commented Jul 31, 2023

@michaelcadilhac I've found a benchmark for which the assertion below does not hold. See 07.tlsf in the realizable benchmarks in tests. Why did we not use at least int?

assert (nb_accepting_states < UCHAR_MAX);

@gaperez64 gaperez64 added the enhancement New feature or request label Jul 31, 2023
@michaelcadilhac michaelcadilhac self-assigned this Nov 23, 2023
@michaelcadilhac
Copy link
Collaborator

I'd call this premature optimization. This allows for a slightly better data structure for the loop that follows, in the code. I'm "refreshing" all integer types with fixed width integer types right now, and this will solve that.

@gaperez64
Copy link
Owner Author

Is it solved now @michaelcadilhac ?

@gaperez64
Copy link
Owner Author

I still see the assertion in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants