-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz : Support Citadel to Fortress Forward Port #784
Labels
ign to gz
Renaming Ignition to Gazebo.
Comments
This was referenced Aug 9, 2022
This was referenced Aug 12, 2022
7 tasks
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Main Parts
Header Migration
TwoThree parter here!using namespace XXX
instance, this group of PR gets rid of MOST of the redundant namespace references.)ignition::
namespace referencesUpon merge of (2), migrate all include statements to gzWe need (2) to merge first because otherwise as we're merging (3) downstream packages will break.(2) must be merged in topological order.
Additionally, to not break ABI,
ignition
has to be the primary/canonical namespace. So usage ofgz
will redirect toignition
.Also, some
config.hh
include statements have been added, andmsgs
was skipped because its headers are generated based off the directory of those headers.Docs Migration
Building Locally
To test locally, you need to manually install the deps (we can't use the script on the installation guide because certain dependencies can't be found on jammy and it'll fail, so I had to edit the actual list (and this is what you see) :> )
Header Migration
Part I: Remove redundant namespace references
Created with a very hacky script (but good enough!) I did some hacky stuff to deal with the edge-cases, but it means some instances might have slipped through.
Because of the hacky stuff being done, the script can't be dropped in easily, but the structure can be followed if needed for other cleanup tasks. So I won't put it into
release-tools
.Additional Note
Additionally, I couldn't get
gz-sim
to compile without adding an include statement foroptional
:PR List
Part II: Create gz -> ignition redirection headers
Created with more hacky scripts.
I pulled from the install space, then redirected it.
PR List
Docs Migration
PR List
The text was updated successfully, but these errors were encountered: