Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP only form should require BP term before allowing curator to save #74

Open
vanaukenk opened this issue Jun 8, 2018 · 3 comments
Open

Comments

@vanaukenk
Copy link

Currently, the BP only version of the form allows curators to save an annotation even if they've only input a gene product name.

The result is an annotation to the root node of MF with no supporting evidence.

The BP only form should require that curators also enter a BP term and evidence before they can save.

Thx.

@vanaukenk
Copy link
Author

@tmushayahama

I've tested and this all looks good now.

Thx.

@vanaukenk
Copy link
Author

vanaukenk commented Jun 26, 2019

Re-visiting this issue since it is possible for a curator to enter just 'PMID:' as a reference and still get the annotation to save.
The reference should have characters and/or numbers after the colon.
Note that this reference behavior is not limited to BP only, but also happens on the Default form.

@tmushayahama
Copy link
Contributor

@vanaukenk I missed this. Will handle it well in Form 2.0 . It will follow these rules (is below premises correct)

  • BP term is required for BP only form but not required for default form
  • If a term is filled then evidence is required
  • If evidence is provided then a reference is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants