Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore adding functionality to create more lines for specific rows in the form #85

Open
vanaukenk opened this issue Oct 16, 2018 · 3 comments

Comments

@vanaukenk
Copy link

From: geneontology/noctua#583

From @suzialeksander
I need to add two "has_input"s to an annotation. Is there a way to tweak the Form? I managed to do this through the Graph Editor but it wasn't intuitive (two different titles for what, to the user, are the same thing: "sub-nodes"/"edge & class expression"

From @vanaukenk
Perhaps we could add a feature to the form that would allow curators to add another row of contextual information, although we will want to be selective about which rows could be duplicated.

@vanaukenk
Copy link
Author

Note that multiple 'has input' relations and values are allowed in the current spec:

https://github.com/geneontology/GO_Shapes/blob/master/shapes/go-cam-shapes.shex

@tmushayahama
Copy link
Contributor

@suzialeksander @vanaukenk yes, this feature will be implemented on Form 2.0 . I am still playing around with how to best expand the form without overwhelming it on its default ( first impressions :) ) @thomaspd had a good suggestion of adding the option on the MF row like below

image

With proper labeling of course. However hiding it like this, means noone will know it's there unless they dig in. Any thoughts?

@vanaukenk
Copy link
Author

Thanks @tmushayahama

I agree that we need to make this functionality more visible.

How about something simple like a '+' sign next to the rows that can have more than one entry (according to the shex specifications, of course)?

Clicking on the '+' sign would generate an additional row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants