Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_bulk_message needs more refined error handling #18

Open
MrCsabaToth opened this issue Oct 12, 2018 · 1 comment
Open

send_bulk_message needs more refined error handling #18

MrCsabaToth opened this issue Oct 12, 2018 · 1 comment

Comments

@MrCsabaToth
Copy link

Right now send_bulk_message can emit BadDeviceToken and a PartialBulkMessage exceptions. When filling the good_registration_ids and bad_registration_ids the exception is pac-man style (catch all) and doesn't really distinguish between various types of errors. Only those 403 TokenError and 410 TokenInactive should be considered as id problems. Otherwise the user's APNs server will inactivate such device tokens which are still valid!

@MrCsabaToth
Copy link
Author

There could be a way to catch and provide the exceptions along with the bad ids, so there won't be a need for extra rounds with send_message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant