diff --git a/tests/unit/app/GeoKrety/Emails/BasePHPMailerSendCopyToAdminTest.php b/tests/unit/app/GeoKrety/Emails/BasePHPMailerSendCopyToAdminTest.php index c5b172b865..2ccded3c57 100644 --- a/tests/unit/app/GeoKrety/Emails/BasePHPMailerSendCopyToAdminTest.php +++ b/tests/unit/app/GeoKrety/Emails/BasePHPMailerSendCopyToAdminTest.php @@ -16,7 +16,7 @@ protected function mockeryTestSetUp() { $this->mailer->allows()->isUnitTesting()->andReturn(true); } - public function testNotFoundAdminsArenotAddedToTheList() { + public function testNotFoundAdminsAreNotAddedToTheList() { $user = UserFixture::getUserFixture(); $this->mailer->shouldAllowMockingProtectedMethods(); @@ -29,11 +29,13 @@ public function testNotFoundAdminsArenotAddedToTheList() { public function testAdminsAreAddedToTheList() { $admin = UserFixture::getUserFixture(1); $user = UserFixture::getUserFixture(2); + $admin_email = $admin->email; $this->mailer->shouldAllowMockingProtectedMethods(); $this->mailer->shouldReceive('getAdmin')->once()->andReturn($admin); $this->assertNull($this->mailer->sendCopyToAdmins($user)); $this->assertCount(1, $this->mailer->recipients); + $this->assertEquals($this->mailer->recipients[0]->email, $admin_email); } } diff --git a/website/app/GeoKrety/Email/BasePHPMailer.php b/website/app/GeoKrety/Email/BasePHPMailer.php index 6f79c181cc..d505038e7b 100644 --- a/website/app/GeoKrety/Email/BasePHPMailer.php +++ b/website/app/GeoKrety/Email/BasePHPMailer.php @@ -190,7 +190,6 @@ public function sendCopyToAdmins(User $user): void { if (is_null($admin)) { continue; } - $admin->email = $user->email; $admin->username .= $user->username.' (admin)'; $this->recipients[] = $admin; }