Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about bulk load #155

Closed
jerabaul29 opened this issue Jan 19, 2024 · 5 comments
Closed

Documentation about bulk load #155

jerabaul29 opened this issue Jan 19, 2024 · 5 comments

Comments

@jerabaul29
Copy link
Contributor

rstar/rstar/src/rtree.rs

Lines 98 to 101 in c7d53c8

/// # Bulk loading
/// In many scenarios, insertion is only carried out once for many points. In this case,
/// [RTree::bulk_load] will be considerably faster. Its total run time
/// is still `O(log(n))`. **Note the performance caveat related to the computation of the envelope**.

is still `O(log(n)): should that not be is still `O(n log(n)) for inserting n points, though the scaling factor is significantly improved?

@jerabaul29
Copy link
Contributor Author

(since this inserts n elements at once?)

@rmanoka
Copy link
Contributor

rmanoka commented Jan 23, 2024

Yes, the author probably meant O(log n) per element amortized.

@jerabaul29
Copy link
Contributor Author

I will open a PR to clarify :) .

@grovesNL
Copy link
Contributor

@jerabaul29 looks like this is fixed now

@jerabaul29
Copy link
Contributor Author

Thanks, I just forgot to close this. Closing as solved through #156 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants