Error when login plugin disabled

[hughbris]

I have the login plugin disabled on production, and am using the maintenance plugin for my "coming soon". I have disabled the allow_login option in the maintenance plugin.

I get this error when I load the page:

 49 Pimple\Exception\UnknownIdentifierException
…/vendor/pimple/pimple/src/Pimple/Container.php101

It goes away when I re-enable the login plugin for my environment, which I am doing for a workaround. I think it should work without having to do this.

[NicoHood]

0 - Identifier "user" is not defined.

I was about to report the exact same issue

[hughbris]

Funny we seem to be noticing and patching a lot of the same issues lately.

[NicoHood]

I am going to write a patch (if you havent done one)...

[hughbris]

Go for it

[NicoHood]

Please checkout #37

I've fixed a bunch of issues, a review would be nice. Also if you have any idea on #33 that'd be nice

[hughbris]

I've fixed a bunch of issues, a review would be nice. Also if you have any idea on #33 that'd be nice

Sorry I don't have the time right now. The core maintainers will get to it in time and do a great job reviewing.

If you are desperate for the fixes to be integrated into the repos, I've found it pragmatic while I wait to clone from my own fork/branch and then edit my .dependencies file to point to that. That way my patches don't get trampled in an update.

[NicoHood]

Which .dependencies file? I am using git submodules and I could point to my own fork. But I am optimistic that @rhukster will review the simple fixes shortly ;-)

[hughbris]

Which .dependencies file? I am using git submodules and I could point to my own fork. But I am optimistic that @rhukster will review the simple fixes shortly ;-)

It's been a while since I've attempted this. After digging, I'm not so sure I was ever successful. I was able to track down a file with a .dependencies file in the user folder. I think it's meant to replace the one in Grav's root and inform bin/gpm. I couldn't get gpm info to show the alternate repo details from the .dependencies file, and it didn't come up as requiring upgrade, so I'm not sure any more.

If you're not automating upgrades, you can simply skip the forked plugins and upgrade them when required with git.

Sorry for not being able to back up my instruction :/