Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Service Widget - WatchYourLAN #4664

Closed
wants to merge 2 commits into from
Closed

Conversation

danlindow
Copy link

Proposed change

This MR adds support for the WatchYourLAN service. Specifically it renders two counters which represent the known and unknown hosts on a given LAN.

Example Screenshot:
watch_your_lan_unknown

This is a single API operation to the /api/all endpoint and counts the number of known/unknown hosts on the LAN.

There is some interest for this widget as seen here:
#1767
myself included :)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Collaborator

shamoon commented Jan 27, 2025

Naively, I thought that these changes to the PR template would help. Unfortunately not. Still I will show them again so as to emphasize:
Comparing dev featuretruenas-dataset-3493 · gethomepagehomepage

Before opening this pull request please review the guidelines in the
checklist below.
If this PR does not meet those guidelines it will not be accepted, and everyone will be sad.

@shamoon shamoon closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants