Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Licence + Licence status displayed unclearly in the UI #6883

Closed
tobimori opened this issue Dec 25, 2024 · 4 comments · Fixed by #6896
Closed

[v5] Licence + Licence status displayed unclearly in the UI #6883

tobimori opened this issue Dec 25, 2024 · 4 comments · Fixed by #6896
Assignees
Milestone

Comments

@tobimori
Copy link
Contributor

tobimori commented Dec 25, 2024

Description

LicenceStatus description/text doesn't show up in the UI, only in the ARIA label.

This leads to people "abusing" the License text for showing the status, like here:
CleanShot 2024-12-25 at 16 04 38@2x

And this results in inconsistency between free plugins (that show the actual License there).

CleanShot 2024-12-25 at 16 06 09@2x

Expected behavior
Both written License and LicenceStatus text should be visible at all times.

License should be MIT/GPL/etc. or "xyz Plugin License" / "Kirby EULA" / etc.

License status should be "activated", "Buy license", etc.

Consider two separate columns.

Your setup

Kirby Version 5.0-beta.1

@distantnative
Copy link
Member

I agree that two columns could make a lot of sense here, one for the license type and one for status. Some licenses (e.g. MIT) might not have any status (or always just positive).

@tobimori
Copy link
Contributor Author

I think free plugins should have an empty activation status, because there are other CMS like Shopware that require buying a license for free plugins in the store as well, so this might be confusing for new people.

@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative
Copy link
Member

Currently, trying to work on this. Would splitting it up in two columns like this make sense to you, @tobimori?

Screenshot 2025-01-11 at 13 50 23

Probably the strings should be a little different, e.g. as you mention maybe a free plugin shouldn't say Valid license then but some more neutral/passive.

@tobimori
Copy link
Contributor Author

yes that's good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants