“Copy Files” toggle is ignored when duplicating a page

[linusrogge]

Description

When duplicating a page with images, I have to option to set a toggle whether to copy these files or not. But no matter what option it is set to, the files are always copied.

Expected behavior
When the toggle is set to false, no files should appear in the duplicated page.

This looks like the problem. Shouldn’t it be if ($files !== false) { …?

kirby/src/Cms/PageActions.php

Lines 470 to 479 in 94cc37e

	// don't copy files
	if ($files === false) {
	foreach ($this->files() as $file) {
	$ignore[] = $file->root();
	// append all content files
	array_push($ignore, ...$file->storage()->contentFiles('published'));
	array_push($ignore, ...$file->storage()->contentFiles('changes'));
	}
	}

To reproduce

1. Create a page and upload an image
2. Click on “Duplicate” and leave “Copy Files” toggle on false
3. Click duplicate
4. See copied files

Your setup

Kirby Version
4.5.0 (but has been around before)

Your system (please complete the following information)

• Device: MacBook Pro
• OS: macOS Sequoia, Version 15.2 (24C101)
• Browser: Chrome

[afbora]

Hello @linusrogge I've tried on starterkit 4.5.0 and it's working great. Do you have plugins?

Also I just wonder that copy and don't copy actions works for you with $files !== false condition?