Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Update UI of bottam bar instead of direct buttons #174

Open
ajay-prabhakar opened this issue Mar 5, 2019 · 23 comments · May be fixed by #235
Open

Update UI of bottam bar instead of direct buttons #174

ajay-prabhakar opened this issue Mar 5, 2019 · 23 comments · May be fixed by #235

Comments

@ajay-prabhakar
Copy link
Contributor

Problem description

Currently, for a bottom bar, there are directly buttons are there make a better UI and propose below the comments section
the better UI holds for a better user experience so there should be good UI

Expected behavior

good UI design so it holds for good user experience

@ajay-prabhakar
Copy link
Contributor Author

@shobhitagarwal1612 can I work on this thank you!

@ajay-prabhakar
Copy link
Contributor Author

ajay-prabhakar commented Mar 5, 2019

Which I made:

ui

@shobhitagarwal1612
Copy link
Contributor

shobhitagarwal1612 commented Mar 6, 2019

Some padding/margin would make it look even better

@ajay-prabhakar
Copy link
Contributor Author

Just now I added the option that when we click the button the background colur changes to blue like this
Ok I will add some padding now
screenshot_20190306-103225_skunkworks-crow

@iadeelzafar
Copy link
Contributor

@Chromicle Nice work. I think you should improve it this way:

  • When the user clicks on the button, the foreground color(color of the Text) should be white and the color of the background should be the Primary Color of the app.

@ajay-prabhakar
Copy link
Contributor Author

@iadeelzafar Thanks for suggestion but, if I make like that means the app should not look colorful as all the colors are only the primary color only and white so I added the light blue color to that button so it looks good
that is my opinion

@iadeelzafar
Copy link
Contributor

@Chromicle We need to follow Material Design guidelines. It suggests to use two colors i.e. Primary and Secondary.
Material Design

@syedabbashussainnaqvi
Copy link

@shobhitagarwal1612 I would like to do work on it.

@syedabbashussainnaqvi
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Hello @syedabbashussainnaqvi!

You have attempted to claim an issue without the labels "help wanted", "good first issue". It seems like you are new to Open Data Kit, so we suggest working on a good first issue issue first. After doing one quick win, then try a help wanted issue. We also recommend reading README.md and CONTRIBUTING.md before getting started.

To claim this issue anyway, comment on this issue again with the command @opendatakit-bot claim --force.

@ajay-prabhakar
Copy link
Contributor Author

@shobhitagarwal1612 I would like to do work on it.

I already made a PR on this you can find any other new issues

#183

@shobhitagarwal1612
Copy link
Contributor

shobhitagarwal1612 commented Mar 20, 2019

@Chromicle I understand that you raised the issue and wanted to work on it. But unless you claim the issue, how will others know that it is not picked by someone. Please take care of this for future references

@ajay-prabhakar
Copy link
Contributor Author

@opendatakit-bot claim

@getodk-bot
Copy link
Member

getodk-bot commented Apr 2, 2019

Hello @Chromicle, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@ajay-prabhakar
Copy link
Contributor Author

@opendatakit-bot Yeah I am still working on it

@lakshyagupta21
Copy link
Contributor

lakshyagupta21 commented Apr 2, 2019

@Chromicle it looks like you've closed a already raised PR.

@ajay-prabhakar ajay-prabhakar linked a pull request Apr 2, 2019 that will close this issue
2 tasks
@ajay-prabhakar
Copy link
Contributor Author

@lakshyagupta21 due to merge conflicts are there I pushed before all commits so I closed that

@lakshyagupta21
Copy link
Contributor

I know sometimes merge conflicts are difficult to resolve but you shouldn't do this kind of practice if you face any such issues. And if you face any difficulties with Git let us know we'll help you out.

@ajay-prabhakar
Copy link
Contributor Author

Apologizes for that, from next time onwards I will make sure that it does not happen

@devanshi7799
Copy link
Contributor

@lakshyagupta21 @Chromicle is this issue still open?

@ajay-prabhakar
Copy link
Contributor Author

I updated my PR and it is under review

@devanshi7799
Copy link
Contributor

devanshi7799 commented Jan 19, 2020

@Chromicle @lakshyagupta21 instead of button, can we use FABs?
it would look good.

@ajay-prabhakar
Copy link
Contributor Author

I don't think fabs look good for 2 buttons in the bottom it is bad UI, we use the fab if we have only one button
I wrote the style for the button please have a look on it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants