-
Notifications
You must be signed in to change notification settings - Fork 73
Update UI of bottam bar instead of direct buttons #174
Comments
@shobhitagarwal1612 can I work on this thank you! |
Some padding/margin would make it look even better |
@Chromicle Nice work. I think you should improve it this way:
|
@iadeelzafar Thanks for suggestion but, if I make like that means the app should not look colorful as all the colors are only the primary color only and white so I added the light blue color to that button so it looks good |
@Chromicle We need to follow Material Design guidelines. It suggests to use two colors i.e. Primary and Secondary. |
@shobhitagarwal1612 I would like to do work on it. |
@opendatakit-bot claim |
Hello @syedabbashussainnaqvi! You have attempted to claim an issue without the labels "help wanted", "good first issue". It seems like you are new to Open Data Kit, so we suggest working on a good first issue issue first. After doing one quick win, then try a help wanted issue. We also recommend reading README.md and CONTRIBUTING.md before getting started. To claim this issue anyway, comment on this issue again with the command |
I already made a PR on this you can find any other new issues |
@Chromicle I understand that you raised the issue and wanted to work on it. But unless you claim the issue, how will others know that it is not picked by someone. Please take care of this for future references |
@opendatakit-bot claim |
Hello @Chromicle, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
@opendatakit-bot Yeah I am still working on it |
@Chromicle it looks like you've closed a already raised PR. |
@lakshyagupta21 due to merge conflicts are there I pushed before all commits so I closed that |
I know sometimes merge conflicts are difficult to resolve but you shouldn't do this kind of practice if you face any such issues. And if you face any difficulties with Git let us know we'll help you out. |
Apologizes for that, from next time onwards I will make sure that it does not happen |
@lakshyagupta21 @Chromicle is this issue still open? |
I updated my PR and it is under review |
@Chromicle @lakshyagupta21 instead of button, can we use FABs? |
I don't think fabs look good for 2 buttons in the bottom it is bad UI, we use the fab if we have only one button |
Problem description
Currently, for a bottom bar, there are directly buttons are there make a better UI and propose below the comments section
the better UI holds for a better user experience so there should be good UI
Expected behavior
good UI design so it holds for good user experience
The text was updated successfully, but these errors were encountered: