-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage PSR-17 to use generic PSR-7 factories #693
Comments
I've tried multimple times, but I can't require the virtual package...
@ste93cry you where able to do it with PSR-7, how did you do it? |
I talked to @ste93cry and checked on HTTPlug progress. It seems that PSR-17 is too young for now, and they don't support it for now: php-http/message-factory#37 We should leave this issue open, but remove the milestone since it's not feasible now, in the short term. |
Hello all! The PSR-17 and PSR-18 specifications for factories and HTTP clients respectively have seen improved adoption since this issue was created, with Guzzle now directly implementing PSR-18 and the It would be really nice to see a version of this library that's decoupled from httplug and supports using any implementation of the PSR spec instead, so we can bring our own versions of each if our application already uses them. |
Even though we didn't talk about this yet, I strongly think that we are gonna do this in |
As reported in https://github.com/getsentry/sentry-php/pull/682/files#r231547783, we can leverage PSR-17 to not rely on Diactoros directly to obtain the PSR-7 request object during event generation.
The text was updated successfully, but these errors were encountered: