Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pragma once #8

Open
griswaldbrooks opened this issue Sep 29, 2020 · 0 comments
Open

Revert pragma once #8

griswaldbrooks opened this issue Sep 29, 2020 · 0 comments

Comments

@griswaldbrooks
Copy link
Member

griswaldbrooks commented Sep 29, 2020

#pragma once is a non-portable extension.
https://github.com/gillwald/geometry/blob/master/include/gillwald/geometry.hpp#L3
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rs-guards
https://stackoverflow.com/questions/1143936/pragma-once-vs-include-guards/34884735#34884735

We should go back to include guards, until we can use modules
https://en.cppreference.com/w/cpp/language/modules
https://www.modernescpp.com/index.php/cpp20-modules

This, of course, will require us to pick an include guard format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant