Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tackle the Python dependencies versus plugins issue #33

Closed
gingeleski opened this issue Feb 21, 2019 · 4 comments
Closed

Tackle the Python dependencies versus plugins issue #33

gingeleski opened this issue Feb 21, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@gingeleski
Copy link
Owner

It's occurred to me that while plugins are currently really modular, they typically carry overhead in the form of Python dependencies they need.

So that "modularity" is sandbagged by the fact that the overall requirements.txt file has to be updated to include those.

This is a design issue which needs to be addressed in one form or another... maybe alongside #32

@gingeleski gingeleski added the enhancement New feature or request label Feb 21, 2019
@gingeleski gingeleski self-assigned this Feb 21, 2019
@gingeleski
Copy link
Owner Author

Gave this some thought; think plugin interface should have each of them declare a list of dependencies.

Somehow these are all sorted out into one consolidated requirements.txt.

It's better than how things are currently, until I/"we" figure something even better than this.

@gingeleski gingeleski changed the title Think through the Python dependencies versus plugins issue Tackle the Python dependencies versus plugins issue Feb 23, 2019
@gingeleski
Copy link
Owner Author

Prototyping this in a separate branch

@gingeleski
Copy link
Owner Author

Currently missing requirements for the plugins in requirements.txt ... have to diff, isolate the ones needed, then add some field (DEPENDENCIES ?) to the plugin interface before finally adding back the specific deps as needed

@gingeleski
Copy link
Owner Author

Things this needs still:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant