Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Husky to run eslint on staged files before commit #488

Open
1 task done
caushcani opened this issue Dec 13, 2024 · 2 comments
Open
1 task done

Configure Husky to run eslint on staged files before commit #488

caushcani opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
type: feature-request New feature or request

Comments

@caushcani
Copy link

🔖 Feature description

By integrating Husky with lint-staged, we can ensure that only code that passes ESLint checks is committed, helping to maintain consistent code quality and style across the repository.
Also, we don't have to fix eslint warning after we open a PR. Let's solve it locally, then do a PR.

🎤 Why is this feature needed ?

To ensure that all code meets the linting standards before it's committed, reducing the need for last-minute fixes and ensuring a smoother, more consistent PR process. This helps maintain high code quality throughout development

✌️ How do you aim to achieve this?

  1. Install Husky and lint-staged
  2. Set up Husky pre-commit hook

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

@caushcani caushcani added the type: feature-request New feature or request label Dec 13, 2024
@caushcani
Copy link
Author

@nevo-david, if you think this would help the project, I can start working on the implementation and submit a PR. Otherwise, I can close this issue.

@nevo-david
Copy link
Contributor

@caushcani feel free to try it, but it might not compile the project you would need to do some changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants