Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Found a couple issues so far #7

Open
MrGurns opened this issue Feb 12, 2018 · 3 comments
Open

Found a couple issues so far #7

MrGurns opened this issue Feb 12, 2018 · 3 comments

Comments

@MrGurns
Copy link

MrGurns commented Feb 12, 2018

Delete on android doesn't work, It does on iOS
Underlines are drawn on Android, not on iOS (might want to use underlineColorAndroid='transparent')
Styling differences amongst android and ios, Could better utilize the default styling to be justified and aligned instead of offsets.

@MrGurns
Copy link
Author

MrGurns commented Feb 12, 2018

Furthermore, allowing entry into this for assigning a pin would also be cool.
This would require a change to not auto set the focus, but to handle receiving it, as well as a value field, and very minimum an onChange() field.
Utilizing the same layout as a TextField or other default input types from react native could prove useful.

@gkueny
Copy link
Owner

gkueny commented Feb 13, 2018

Hi !

Thanks for your comments !

  • "Delete on android doesn't work, It does on iOS" => Should be fixed with react-native 0.53

  • for your other remarks, I will take a look in the week, btw, PR is appreciated :)

@MrGurns
Copy link
Author

MrGurns commented Feb 13, 2018

If i have some time here in the future, i may contribute. Currently have to get this app done first tho.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants