Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing a Node object in another package as data produces a warning when lazy loading of data is used #173

Open
jranke opened this issue Dec 18, 2024 · 1 comment

Comments

@jranke
Copy link

jranke commented Dec 18, 2024

When enabling lazy loading of data in a package that contains a Node object, we get a warning in the package check.

* checking whether package ‘data.tree.in.package’ can be installed ... WARNING
Found the following significant warnings:
  Warning in (function ()  : 'Node$fields' is deprecated.
  Warning in (function ()  : 'Node$fieldsAll' is deprecated.
See ‘/home/[email protected]/projects/data.tree.in.package/data.tree.in.package.Rcheck/00install.out’ for details.

Apparently, Node$fields and Node$fieldsAll are called under these circumstances.

This is related to the deprecation of these methods and has already been discussed elsewhere [1], but there is no open issue in this package currently. I have created an example package that passes R CMD check without warnings before switching on lazy loading of data, but produces the warning after that [2].

[1] ncss-tech/interpretation-engine#3
[2] jranke/data.tree.in.package@b8c7a81

jranke added a commit to agroscope-ch/srppphist that referenced this issue Dec 18, 2024
With this github  workflow, the warning produced in the package check
because of including the culture trees as `Node` objects from the
`data.tree` package does not make the check fail. See
gluc/data.tree#173
@gluc
Copy link
Owner

gluc commented Dec 19, 2024

Thx, will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants