Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_lighter.sc is broken in 1.21 #406

Open
A-jar-of-dirt opened this issue Aug 20, 2024 · 2 comments · May be fixed by #416
Open

auto_lighter.sc is broken in 1.21 #406

A-jar-of-dirt opened this issue Aug 20, 2024 · 2 comments · May be fixed by #416
Labels
bug Something isn't working

Comments

@A-jar-of-dirt
Copy link

Describe the bug
appears to just instantly delete the torches from the inventory when right clicking.

To Reproduce
Steps to reproduce the behavior:

  1. in survival 1.21.1 fabric
  2. right click on a stack of torches
  3. watch it instantaneously disappear

Expected behavior
be like jesus with torches streaming from my face

Environment

  • Carpet version: fabric-carpet-1.21-1.4.147+v240613
  • Minecraft version: client: fabric 1.21 server: fabric 1.21
@A-jar-of-dirt A-jar-of-dirt added the bug Something isn't working label Aug 20, 2024
@GDACK
Copy link

GDACK commented Nov 4, 2024

Confirmed. 1.21 Fabric. 1.21 Carpet

An entire stack of torches just instantly disappears without placing them.

jnovack added a commit to jnovack/scarpet that referenced this issue Jan 11, 2025
@jnovack
Update auto_lighter.sc for v1.21
75ca7c2 
Updates auto_lighter to check for version, and appropriately use Enchantments (<1.21) vs components (v1.21+) depending on version.

Corrective snipped merged from @YageGeng in gnembon#395 

Fixes gnembon#395 
Fixes gnembon#405 
Fixes gnembon#406
@jnovack jnovack linked a pull request Jan 11, 2025 that will close this issue
Open
@jnovack
Copy link

jnovack commented Jan 11, 2025 •
edited
Loading

Dupe of #395. May be fixed in #416.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update auto_lighter.sc for v1.21 jnovack/scarpet
3 participants
@jnovack @GDACK @A-jar-of-dirt