Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code may not handle CR newlines correctly #3

Open
brown opened this issue Jul 5, 2018 · 1 comment
Open

code may not handle CR newlines correctly #3

brown opened this issue Jul 5, 2018 · 1 comment

Comments

@brown
Copy link

brown commented Jul 5, 2018

Your code uses reader.ReadLine() to break a jar manifest into separate lines. When I looked at the code for that function, it did not appear to treat lone CR (carriage return) characters as line terminators. The spec for jar file manifests says that a newline is denoted by CR NL, NL alone, or CR alone.

Here is a link to the spec: https://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html#Manifest_Specification

@gnewton
Copy link
Owner

gnewton commented Jul 5, 2018

I will look in to this. I may try to create a jar file which causes things to break due to this issue.
Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants