Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestBenchmarkBytes fails on Windows #105

Open
rillig opened this issue Aug 29, 2018 · 1 comment
Open

TestBenchmarkBytes fails on Windows #105

rillig opened this issue Aug 29, 2018 · 1 comment

Comments

@rillig
Copy link

rillig commented Aug 29, 2018

To reproduce:

Output:

FAIL: benchmark_test.go:62: BenchmarkS.TestBenchmarkBytes

benchmark_test.go:74:
    c.Assert(output.value, Matches, expected)
... value string = "PASS: check_test.go:151: FixtureHelper.Benchmark2\t      10\t   1597640 ns/op\t   0.64 MB/s\n"
... regex string = "PASS: check_test\\.go:[0-9]+: FixtureHelper\\.Benchmark2\t\\s+[0-9]+\t\\s+[0-9]+ ns/op\t\\s+ *[1-9]\\.[0-9]{2} MB/s\n"

The test fails because 0.64 MB/s doesn't match [1-9]\.\d+.

@jhenstridge
Copy link
Contributor

This looks to be fixed by 10cb982 (which updates the CI to run the test suite on Windows), which makes the suggested change to the regexp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants