Missing rollup function

[matiza5]

Hello,

I'm using GraphiteMergeTree with rollup function 'quantile' (https://clickhouse-docs.readthedocs.io/en/latest/agg_functions/#quantile-level-x). It seems that graphite-clcikhouse does not support this function.

2020/01/14 10:48:19 unknown function "quantile(0.95)"

It probably should be here: https://github.com/lomik/graphite-clickhouse/blob/a6fed39d02064bf520d2201dfdfafd341a66d051/helper/rollup/aggr.go

Is it possible to add it ? :)

Regads,
Mateusz

[Felixoid]

Hey @matiza5, it's a little bit complex to implement.

Although it's possible. And, I guess, after the recently implemented ClickHouse internal aggregation feature it makes sense.

The idea is to use whatever function is defined in the rollup config with the fallback to avg, but if the rollup is done in graphite-clickhouse itself, log the warning. It will work for the case when internal-aggregation=true and carbonlink isn't used.

update
Worth to mention the carbon storage-aggregation and cosolidateBy function documentation. Currently, graphite-clickhouse supports all of them, and with custom functions, it definitely will be an extension