-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in comment: 'finish' should be 'cancel' #1647
Conversation
WalkthroughThis pull request introduces two main changes: adding a new author to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
connection.go (1)
438-438
: Correct the grammatical error in the function comment.The comment currently reads:
// cancel is called when the query has canceled.
Consider changing it to:// cancel is called when the query is canceled.
Apply this diff to correct the comment:
-// cancel is called when the query has canceled. +// cancel is called when the query is canceled.AUTHORS (1)
95-95
: Insert the author entry in alphabetical order.The added author
Minh Quang
should be placed in the list alphabetically by first name. Please consider moving the entry afterMichael Woolnough
.Apply this diff to reorder the entry:
Michael Woolnough <michael.woolnough at gmail.com> +Minh Quang <minhquang4334 at gmail.com> Nao Yokotsuka <yokotukanao at gmail.com>
Description
Fix #1646
Checklist
Summary by CodeRabbit
New Features
AUTHORS
file.Improvements
Bug Fixes